From 2f89043b35a58afac2d731982cbb499cd4d06f5d Mon Sep 17 00:00:00 2001 From: ptitSeb Date: Sat, 20 Mar 2021 21:11:49 +0100 Subject: [DYNAREC] Various bugfixes (and now the 4 tests games works again) --- src/dynarec/dynarec_arm64_00.c | 10 ++--- src/dynarec/dynarec_arm64_66.c | 4 +- src/dynarec/dynarec_arm64_emit_logic.c | 78 +++++++++++++++++----------------- src/dynarec/dynarec_arm64_emit_math.c | 26 ++++++------ src/dynarec/dynarec_arm64_helper.h | 2 +- src/emu/x64run_private.c | 21 +++++++-- src/include/regs.h | 1 + 7 files changed, 78 insertions(+), 64 deletions(-) diff --git a/src/dynarec/dynarec_arm64_00.c b/src/dynarec/dynarec_arm64_00.c index 61a18f8f..c46d78ff 100755 --- a/src/dynarec/dynarec_arm64_00.c +++ b/src/dynarec/dynarec_arm64_00.c @@ -98,8 +98,8 @@ uintptr_t dynarec64_00(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin SETFLAGS(X_ALL, SF_SET); u8 = F8; UXTBw(x1, xRAX); - emit_add8c(dyn, ninst, x1, u8, x3, x4, x5); - BFIw(xRAX, x1, 0, 8); + emit_add8c(dyn, ninst, x1, u8, x3, x4); + BFIx(xRAX, x1, 0, 8); break; case 0x05: INST_NAME("ADD EAX, Id"); @@ -149,7 +149,7 @@ uintptr_t dynarec64_00(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin u8 = F8; UXTBw(x1, xRAX); emit_or8c(dyn, ninst, x1, u8, x3, x4); - BFIw(xRAX, x1, 0, 8); + BFIx(xRAX, x1, 0, 8); break; case 0x0D: INST_NAME("OR EAX, Id"); @@ -416,7 +416,7 @@ uintptr_t dynarec64_00(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin u8 = F8; UXTBw(x1, xRAX); emit_xor8c(dyn, ninst, x1, u8, x3, x4); - BFIw(xRAX, x1, 0, 8); + BFIx(xRAX, x1, 0, 8); break; case 0x35: INST_NAME("XOR EAX, Id"); @@ -563,7 +563,7 @@ uintptr_t dynarec64_00(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin SETFLAGS(X_ALL, SF_SET); GETEB(x1, 1); u8 = F8; - emit_add8c(dyn, ninst, x1, u8, x2, x4, x5); + emit_add8c(dyn, ninst, x1, u8, x2, x4); EBBACK; break; case 1: //OR diff --git a/src/dynarec/dynarec_arm64_66.c b/src/dynarec/dynarec_arm64_66.c index 10c214f7..024404e0 100755 --- a/src/dynarec/dynarec_arm64_66.c +++ b/src/dynarec/dynarec_arm64_66.c @@ -106,7 +106,7 @@ uintptr_t dynarec64_66(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin UXTHw(x1, xRAX); MOV32w(x2, i32); emit_or16(dyn, ninst, x1, x2, x3, x4); - BFIw(xRAX, x1, 0, 16); + BFIx(xRAX, x1, 0, 16); break; case 0x0F: @@ -227,7 +227,7 @@ uintptr_t dynarec64_66(dynarec_arm_t* dyn, uintptr_t addr, uintptr_t ip, int nin UXTHw(x1, xRAX); MOV32w(x2, i32); emit_sub16(dyn, ninst, x1, x2, x3, x4); - BFIw(xRAX, x1, 0, 16); + BFIx(xRAX, x1, 0, 16); break; case 0x31: diff --git a/src/dynarec/dynarec_arm64_emit_logic.c b/src/dynarec/dynarec_arm64_emit_logic.c index 9d12d333..141322db 100755 --- a/src/dynarec/dynarec_arm64_emit_logic.c +++ b/src/dynarec/dynarec_arm64_emit_logic.c @@ -37,14 +37,14 @@ void emit_or32(dynarec_arm_t* dyn, int ninst, rex_t rex, int s1, int s2, int s3, IFX(X_PEND) { STRxw_U12(s1, xEmu, offsetof(x64emu_t, res)); } - IFX(X_CF | X_AF | X_ZF | X_OF) { - MOV32w(s3, (1<res.u8 & 0x100, F_CF); + CONDITIONAL_SET_FLAG(emu->res.u16 & 0x100, F_CF); CONDITIONAL_SET_FLAG((emu->res.u8 & 0xff) == 0, F_ZF); CONDITIONAL_SET_FLAG(emu->res.u8 & 0x80, F_SF); CONDITIONAL_SET_FLAG(PARITY(emu->res.u8 & 0xff), F_PF); @@ -780,7 +780,7 @@ void UpdateFlags(x64emu_t *emu) CONDITIONAL_SET_FLAG(cc & 0x8, F_AF); break; case d_adc16: - CONDITIONAL_SET_FLAG(emu->res.u16 & 0x10000, F_CF); + CONDITIONAL_SET_FLAG(emu->res.u32 & 0x10000, F_CF); CONDITIONAL_SET_FLAG((emu->res.u16 & 0xffff) == 0, F_ZF); CONDITIONAL_SET_FLAG(emu->res.u16 & 0x8000, F_SF); CONDITIONAL_SET_FLAG(PARITY(emu->res.u16 & 0xff), F_PF); @@ -789,7 +789,7 @@ void UpdateFlags(x64emu_t *emu) CONDITIONAL_SET_FLAG(cc & 0x8, F_AF); break; case d_adc32: - CONDITIONAL_SET_FLAG(emu->res.u32 & 0x100000000L, F_CF); + CONDITIONAL_SET_FLAG(emu->res.u64 & 0x100000000L, F_CF); CONDITIONAL_SET_FLAG((emu->res.u32 & 0xffffffff) == 0, F_ZF); CONDITIONAL_SET_FLAG(emu->res.u32 & 0x80000000, F_SF); CONDITIONAL_SET_FLAG(PARITY(emu->res.u32 & 0xff), F_PF); @@ -797,6 +797,21 @@ void UpdateFlags(x64emu_t *emu) CONDITIONAL_SET_FLAG(XOR2(cc >> 30), F_OF); CONDITIONAL_SET_FLAG(cc & 0x8, F_AF); break; + case d_adc32b: + if(emu->res.u32 == (emu->op1.u32+emu->op2.u32)) { + lo = (emu->op1.u32 & 0xFFFF) + (emu->op2.u32 & 0xFFFF); + } else { + lo = 1 + (emu->op1.u32 & 0xFFFF) + (emu->op2.u32 & 0xFFFF); + } + hi = (lo >> 16) + (emu->op1.u32 >> 16) + (emu->op2.u32 >> 16); + CONDITIONAL_SET_FLAG(hi & 0x10000, F_CF); + CONDITIONAL_SET_FLAG(!emu->res.u32, F_ZF); + CONDITIONAL_SET_FLAG(emu->res.u32 & 0x80000000, F_SF); + CONDITIONAL_SET_FLAG(PARITY(emu->res.u64 & 0xff), F_PF); + cc = (emu->op2.u32 & emu->op1.u32) | ((~emu->res.u32) & (emu->op2.u32 | emu->op1.u32)); + CONDITIONAL_SET_FLAG(XOR2(cc >> 30), F_OF); + CONDITIONAL_SET_FLAG(cc & 0x8, F_AF); + break; case d_adc64: if(emu->res.u64 == (emu->op1.u64+emu->op2.u64)) { lo = (emu->op1.u64 & 0xFFFFFFFF) + (emu->op2.u64 & 0xFFFFFFFF); diff --git a/src/include/regs.h b/src/include/regs.h index 44cc21b8..91deee65 100755 --- a/src/include/regs.h +++ b/src/include/regs.h @@ -109,6 +109,7 @@ typedef enum { d_adc8, d_adc16, d_adc32, + d_adc32b, d_adc64, d_sbb8, d_sbb16, -- cgit 1.4.1