diff options
Diffstat (limited to 'mailinglist/output_launchpad/1393440')
| -rw-r--r-- | mailinglist/output_launchpad/1393440 | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/mailinglist/output_launchpad/1393440 b/mailinglist/output_launchpad/1393440 new file mode 100644 index 00000000..0febd12e --- /dev/null +++ b/mailinglist/output_launchpad/1393440 @@ -0,0 +1,21 @@ +pcie.c:148: possible error in OR expression ? + +[qemu/hw/pci/pcie.c:148] -> [qemu/hw/pci/pcie.c:148]: (style) Same expression on both sides of '|'. + + pci_long_test_and_set_mask(dev->w1cmask + pos + PCI_EXP_DEVSTA, + PCI_EXP_DEVSTA_CED | PCI_EXP_DEVSTA_NFED | + PCI_EXP_DEVSTA_URD | PCI_EXP_DEVSTA_URD); + +I am guessing that something like + + pci_long_test_and_set_mask(dev->w1cmask + pos + PCI_EXP_DEVSTA, + PCI_EXP_DEVSTA_CED | PCI_EXP_DEVSTA_NFED | + PCI_EXP_DEVSTA_FED | PCI_EXP_DEVSTA_URD); + +was intended. + +I used static analyser cppcheck to find this bug. + +Fixed here: +http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8e815eeefe205155f5 + |