diff options
Diffstat (limited to 'mailinglist/output_launchpad/1918026')
| -rw-r--r-- | mailinglist/output_launchpad/1918026 | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/mailinglist/output_launchpad/1918026 b/mailinglist/output_launchpad/1918026 new file mode 100644 index 00000000..13583b4e --- /dev/null +++ b/mailinglist/output_launchpad/1918026 @@ -0,0 +1,40 @@ +RISCV64 32-bit AMOs incorrectly simulated + +Version: qemu-riscv64 version 4.2.1 (Debian 1:4.2-3ubuntu6.14) + +test: + amomaxu.w a0, a1, (a0) + ret + +int32_t* value = -7; +EXPECT_EQ(-7, test(&value, -11)); +EXPECT_EQ(-7, value); // FAIL, saw -11 +EXPECT_EQ(-7, test(&value, -7)); +EXPECT_EQ(-7, value); // FAIL, raw -11 +EXPECT_EQ(-7, test(&value, -4)); +EXPECT_EQ(-4, value); + +test: + amomax.w a0, a1, (a0) + ret + +int32_t* value = -7; +EXPECT_EQ(-7, test(&value, -11)); +EXPECT_EQ(-7, value); +EXPECT_EQ(-7, test(&value, -7)); +EXPECT_EQ(-7, value); +EXPECT_EQ(-7, test(&value, -4)); +EXPECT_EQ(-4, value); // FAIL, saw -7 + +I suspect that trans_amo<op>_w should be using tcg_gen_atomic_fetch_<op>_i32 instead of tcg_gen_atomic_fetch_<op>_tl. + +Not as simple as _tl vs _i32. That suffix should be taking +care of the sign-extension to _tl that happens after the +operation. The size of the operation should be in the MO_TESL, +which specifies target-endian signed "long" (32-bit). + +Will investigate further. + +Flushing out the report to something that compiles, +the test case works for me using qemu 5.2. + |