diff options
Diffstat (limited to 'results/classifier/105/device/1926995')
| -rw-r--r-- | results/classifier/105/device/1926995 | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/results/classifier/105/device/1926995 b/results/classifier/105/device/1926995 new file mode 100644 index 00000000..01c32dd9 --- /dev/null +++ b/results/classifier/105/device/1926995 @@ -0,0 +1,38 @@ +device: 0.845 +vnc: 0.808 +instruction: 0.690 +network: 0.688 +socket: 0.581 +graphic: 0.441 +semantic: 0.441 +boot: 0.385 +other: 0.284 +KVM: 0.220 +mistranslation: 0.180 +assembly: 0.076 + +hw/remote/mpqemu-link.c:221: bad error checking ? + +hw/remote/mpqemu-link.c:221:36: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] + +Source code is + + if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) { + return false; + } + +Maybe better code: + + if (msg->cmd >= MPQEMU_CMD_MAX || msg->cmd < 0) { + return false; + } + +It might be useful to switch on gcc compiler flag -Wlogical-op +to see these warnings. + +Thanks, I've reported it on the mailing list, and a patch has now been posted here: +https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg02106.html + +Fix has been merged now: +https://gitlab.com/qemu-project/qemu/-/commit/dcf20655ffca2b0219d2914d + |