1 files changed, 55 insertions, 0 deletions
diff --git a/results/classifier/111/review/961757 b/results/classifier/111/review/961757
new file mode 100644
index 00000000..0471945f
--- /dev/null
+++ b/results/classifier/111/review/961757
@@ -0,0 +1,55 @@
+other: 0.187
+semantic: 0.180
+device: 0.102
+graphic: 0.091
+files: 0.083
+PID: 0.061
+performance: 0.048
+vnc: 0.046
+debug: 0.044
+socket: 0.041
+boot: 0.039
+permissions: 0.034
+network: 0.032
+KVM: 0.014
+debug: 0.434
+semantic: 0.141
+other: 0.106
+files: 0.067
+device: 0.053
+PID: 0.046
+performance: 0.038
+network: 0.026
+boot: 0.025
+socket: 0.016
+vnc: 0.015
+graphic: 0.014
+permissions: 0.014
+KVM: 0.006
+
+wrong error for blockdev-snapshot-sync
+
+From Laszlo Ersek:
+
+>> +    proto_drv = bdrv_find_protocol(snapshot_file);
+>>      if (!proto_drv) {
+>> -        qerror_report(QERR_INVALID_BLOCK_FORMAT, format);
+>> -        ret = -1;
+>> -        goto out;
+>> +        error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
+>> +        return;
+>>      }
+> 
+> I don't understand the logic here (based on the error message). We
+> specified "format" for the case when a completely new snapshot file has
+> to be created. If the file exists already, then bdrv_find_protocol()
+> tries to find the driver for it. If that fails, then we must report an
+> error indeed, but instead of referring to "format", we'd have to report
+> the "scheme" from the beginning of "snapshot_file".
+
+Which version of QEMU was this? Is this still a problem with the latest version of QEMU?
+
+I can't find anything in the blockdev-snapshot-sync path that has this code in it still. Think it's a non-issue in 2017.
+
+[Expired for QEMU because there has been no activity for 60 days.]
+