summary refs log tree commit diff stats
path: root/results/scraper/launchpad/1393486
diff options
context:
space:
mode:
Diffstat (limited to 'results/scraper/launchpad/1393486')
-rw-r--r--results/scraper/launchpad/139348619
1 files changed, 19 insertions, 0 deletions
diff --git a/results/scraper/launchpad/1393486 b/results/scraper/launchpad/1393486
new file mode 100644
index 00000000..9a103b42
--- /dev/null
+++ b/results/scraper/launchpad/1393486
@@ -0,0 +1,19 @@
+hw/virtio/virtio-rng.c:150: bad test ?
+
+hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
+
+    if (!vrng->conf.period_ms > 0) {
+        error_setg(errp, "'period' parameter expects a positive integer");
+        return;
+    }
+
+Maybe better code
+
+    if (vrng->conf.period_ms <= 0) {
+        error_setg(errp, "'period' parameter expects a positive integer");
+        return;
+    }
+
+Fixed here:
+http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a3a292c420d2fec3c07
+