diff options
Diffstat (limited to 'results/scraper/launchpad/1813460')
| -rw-r--r-- | results/scraper/launchpad/1813460 | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/results/scraper/launchpad/1813460 b/results/scraper/launchpad/1813460 new file mode 100644 index 00000000..6083aab6 --- /dev/null +++ b/results/scraper/launchpad/1813460 @@ -0,0 +1,21 @@ +qemu/target/arm/translate-a64.c:2039: bad test ? + +qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction always evaluates to true: op3 != 2 || op3 != 3. + +Source code is + + if (op3 != 2 || op3 != 3) { + +Maybe better code + + if (op3 != 2 && op3 != 3) { + +Maybe using gcc flag -Wlogical-op might help find bugs like this in future. + +There is a patch on list for this: +https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html + +Using the flag is a good idea. + +The patch is now in master. + |