permissions: 0.172
PID: 0.081
device: 0.081
vnc: 0.079
other: 0.074
semantic: 0.066
debug: 0.065
files: 0.063
KVM: 0.062
performance: 0.056
graphic: 0.054
socket: 0.051
network: 0.048
boot: 0.047
boot: 0.224
files: 0.203
device: 0.143
vnc: 0.115
PID: 0.114
debug: 0.060
other: 0.050
semantic: 0.022
socket: 0.016
KVM: 0.013
performance: 0.012
permissions: 0.012
network: 0.010
graphic: 0.007

[Qemu-devel] [BUG] checkpatch.pl hangs on target/mips/msa_helper.c

If  checkpatch.pl is applied (using switch "-f") on file 
target/mips/msa_helper.c, it will hang.

There is a workaround for this particular file:

These lines in msa_helper.c:

        uint## BITS ##_t S = _S, T = _T;                            \
        uint## BITS ##_t as, at, xs, xt, xd;                        \

should be replaced with:

        uint## BITS ## _t S = _S, T = _T;                           \
        uint## BITS ## _t as, at, xs, xt, xd;                       \

(a space is added after the second "##" in each line)

The workaround is found by partial deleting and undeleting of the code in 
msa_helper.c in binary search fashion.

This workaround will soon be submitted by me as a patch within a series on misc 
MIPS issues.

I took a look at checkpatch.pl code, and it looks it is fairly complicated to 
fix the issue, since it happens in the code segment involving intricate logic 
conditions.

Regards,
Aleksandar

On Wed, Jul 04, 2018 at 03:35:18PM +0000, Aleksandar Markovic wrote:
>
If  checkpatch.pl is applied (using switch "-f") on file
>
target/mips/msa_helper.c, it will hang.
>
>
There is a workaround for this particular file:
>
>
These lines in msa_helper.c:
>
>
uint## BITS ##_t S = _S, T = _T;                            \
>
uint## BITS ##_t as, at, xs, xt, xd;                        \
>
>
should be replaced with:
>
>
uint## BITS ## _t S = _S, T = _T;                           \
>
uint## BITS ## _t as, at, xs, xt, xd;                       \
>
>
(a space is added after the second "##" in each line)
>
>
The workaround is found by partial deleting and undeleting of the code in
>
msa_helper.c in binary search fashion.
>
>
This workaround will soon be submitted by me as a patch within a series on
>
misc MIPS issues.
>
>
I took a look at checkpatch.pl code, and it looks it is fairly complicated to
>
fix the issue, since it happens in the code segment involving intricate logic
>
conditions.
Thanks for figuring this out, Aleksandar.  Not sure if anyone else has
the apetite to fix checkpatch.pl.

Stefan
signature.asc
Description:
PGP signature

On 07/11/2018 09:36 AM, Stefan Hajnoczi wrote:
>
On Wed, Jul 04, 2018 at 03:35:18PM +0000, Aleksandar Markovic wrote:
>
> If  checkpatch.pl is applied (using switch "-f") on file
>
> target/mips/msa_helper.c, it will hang.
>
>
>
> There is a workaround for this particular file:
>
>
>
> These lines in msa_helper.c:
>
>
>
>         uint## BITS ##_t S = _S, T = _T;                            \
>
>         uint## BITS ##_t as, at, xs, xt, xd;                        \
>
>
>
> should be replaced with:
>
>
>
>         uint## BITS ## _t S = _S, T = _T;                           \
>
>         uint## BITS ## _t as, at, xs, xt, xd;                       \
>
>
>
> (a space is added after the second "##" in each line)
>
>
>
> The workaround is found by partial deleting and undeleting of the code in
>
> msa_helper.c in binary search fashion.
>
>
>
> This workaround will soon be submitted by me as a patch within a series on
>
> misc MIPS issues.
>
>
>
> I took a look at checkpatch.pl code, and it looks it is fairly complicated
>
> to fix the issue, since it happens in the code segment involving intricate
>
> logic conditions.
>
>
Thanks for figuring this out, Aleksandar.  Not sure if anyone else has
>
the apetite to fix checkpatch.pl.
Anyone else but Paolo ;P
http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01250.html
signature.asc
Description:
OpenPGP digital signature