mistranslation: 0.886
graphic: 0.652
device: 0.520
semantic: 0.472
network: 0.446
instruction: 0.375
socket: 0.344
vnc: 0.288
other: 0.210
boot: 0.142
assembly: 0.091
KVM: 0.080

target-tricore/translate.c:3812: possible bad expression ?


From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:

[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f) == 0x6f' is always false.

Source code is

    if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {

Suggest code rework.

Absolutly correct. The mask should be 0x7f. I will fix that asap.

http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7f13420ec000ad7644b65e