device: 0.832
vnc: 0.739
semantic: 0.676
socket: 0.656
network: 0.616
graphic: 0.600
performance: 0.586
permissions: 0.584
other: 0.575
boot: 0.509
PID: 0.470
files: 0.463
debug: 0.407
KVM: 0.262

FDC reset should reset the MSR

I believe that the MSR resgister should also be reset to zero on a software reset.  All of the FDC hardware I have does this.
The current code leaves the MSR as 0x80, which means that the controller is ready for a write.  The controller should not
be ready for a write while in reset.

fdc.c Line 899
    /* Reset */
    if (!(value & FD_DOR_nRESET)) {
 +      fdctrl->msr = 0x00;
        if (fdctrl->dor & FD_DOR_nRESET) {
            FLOPPY_DPRINTF("controller enter RESET state\n");
        }
    } else {

Is there a test case that this fixes?

I know of no test case.  The reason for the bug report is that I have been doing some studies of the FDC and have noticed that the MSR register is 0x00 during reset.  Before and after the reset it is 0x80, but during the reset it is zero.  I just wanted to make QEMU more like the hardware.

Thanks,
Ben


[Expired for QEMU because there has been no activity for 60 days.]