semantic: 0.231
network: 0.122
files: 0.104
other: 0.101
performance: 0.074
PID: 0.071
device: 0.066
graphic: 0.050
vnc: 0.042
debug: 0.032
boot: 0.030
permissions: 0.029
socket: 0.027
KVM: 0.020
network: 0.580
debug: 0.121
socket: 0.055
other: 0.043
device: 0.043
files: 0.032
PID: 0.029
semantic: 0.019
vnc: 0.018
KVM: 0.017
performance: 0.016
graphic: 0.011
boot: 0.009
permissions: 0.006

tulip driver broken in v5.0.0-rc4

In a qemu-system-hppa system, qemu release v5.0.0-rc, the tulip nic driver is broken.
The tulip nic is detected, even getting DHCP info does work.
But when trying to download bigger files via network, the tulip driver gets stuck.

For example when trying to download a 100MB file:

root@debian:~# wget https://speed.hetzner.de/100MB.bin
--2020-04-23 20:26:43--  https://speed.hetzner.de/100MB.bin
Resolving speed.hetzner.de (speed.hetzner.de)... 88.198.248.254, 2a01:4f8:0:59ed::2
Connecting to speed.hetzner.de (speed.hetzner.de)|88.198.248.254|:443... connected.
<waiting and stuck here>

When reverting this commit, everything works again:
commit 8ffb7265af64ec81748335ec8f20e7ab542c3850
Author: Prasad J Pandit <email address hidden>
Date:   Tue Mar 24 22:57:22 2020 +0530
PATCH: net: tulip: check frame size and r/w data length

Commit 8ffb7265af does make the code safer, but broke the device model.
Instead of setting the error bits when the frame length is incorrect (too big), it simply discards it. The guest is not notified of the error and keeps waiting.

Attached trivial patch fixes it.


Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d9b69640391618045