ppc: 0.820
device: 0.785
network: 0.767
socket: 0.744
mistranslation: 0.737
files: 0.734
register: 0.722
kernel: 0.674
vnc: 0.661
arm: 0.582
graphic: 0.565
semantic: 0.564
user-level: 0.545
x86: 0.543
PID: 0.531
architecture: 0.500
performance: 0.486
risc-v: 0.480
boot: 0.470
hypervisor: 0.468
assembly: 0.468
i386: 0.454
debug: 0.440
VMM: 0.438
KVM: 0.433
peripherals: 0.428
permissions: 0.421
virtual: 0.402
TCG: 0.322

qemu/net/colo-compare.c:288: possible pointless code duplication ?

qemu/net/colo-compare.c:288] -> [qemu/net/colo-compare.c:296]: (style) The if condition is the same as the previous if condition

Source code is

    if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
        if (colo_compare_packet_payload(ppkt, spkt,
                                        ppkt->header_size, spkt->header_size,
                                        ppkt->payload_size)) {
            *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY;
            return true;
        }
    }
    if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
        if (colo_compare_packet_payload(ppkt, spkt,
                                        ppkt->header_size, spkt->header_size,
                                        ppkt->payload_size)) {
            *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY;
            return true;
        }
    }

Maybe the second block was supposed to be different ?

Have fixed in this patch.
https://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02859.html

Thanks
Zhang Chen

The fix is now in master as commit 6d3aaa5b255ffc55a0561 and will be in QEMU 4.0.