hw/virtio/virtio-rng.c:150: bad test ? hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!vrng->conf.period_ms > 0) { error_setg(errp, "'period' parameter expects a positive integer"); return; } Maybe better code if (vrng->conf.period_ms <= 0) { error_setg(errp, "'period' parameter expects a positive integer"); return; } Fixed here: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a3a292c420d2fec3c07