diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2023-12-19 19:22:11 +0100 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2024-01-23 13:22:46 +1000 |
| commit | 0e5e6219ed75f133a14d6bab39f6966540941864 (patch) | |
| tree | f640a0c6f76b6431a4ab53173b61c31858c38a3b | |
| parent | 09be34717190c1620f0c6e5c8765b8da354aeb4b (diff) | |
| download | focaccia-qemu-0e5e6219ed75f133a14d6bab39f6966540941864.tar.gz focaccia-qemu-0e5e6219ed75f133a14d6bab39f6966540941864.zip | |
tcg: Remove unreachable code
The `fail_rx`/`fail` block is only entered while `buf_rx` is equal to its initial value `MAP_FAILED`. The `munmap(buf_rx, size);` was never executed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2030 Signed-off-by: Samuel Tardieu <sam@rfc1149.net> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20231219182212.455952-2-sam@rfc1149.net> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to '')
| -rw-r--r-- | tcg/region.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tcg/region.c b/tcg/region.c index 86692455c0..467e51cf6f 100644 --- a/tcg/region.c +++ b/tcg/region.c @@ -597,9 +597,7 @@ static int alloc_code_gen_buffer_splitwx_memfd(size_t size, Error **errp) fail_rx: error_setg_errno(errp, errno, "failed to map shared memory for execute"); fail: - if (buf_rx != MAP_FAILED) { - munmap(buf_rx, size); - } + /* buf_rx is always equal to MAP_FAILED here and does not require cleanup */ if (buf_rw) { munmap(buf_rw, size); } |