summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJared Rossi <jrossi@linux.ibm.com>2024-11-14 11:19:52 -0500
committerThomas Huth <thuth@redhat.com>2024-11-18 17:14:35 +0100
commit1056ca1e70dc6e0458238141bcebfb7810cede6d (patch)
tree218781550aed4971b4584e5cbdaf2ddd330d96b5
parent8c797468116d19940fb758efa749eae414616e3a (diff)
downloadfocaccia-qemu-1056ca1e70dc6e0458238141bcebfb7810cede6d.tar.gz
focaccia-qemu-1056ca1e70dc6e0458238141bcebfb7810cede6d.zip
pc-bios/s390x: Initialize machine loadparm before probing IPL devices
Commit bb185de423 ("s390x: Add individual loadparm assignment to
CCW device") allowed boot devices to be assigned a loadparm value independent
of the machine value, however, when no boot devices are defined, the machine
loadparm becomes ignored. Therefore, let's check the machine loadparm
prior to probing the devices.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20241114161952.3508554-1-jrossi@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to '')
-rw-r--r--pc-bios/s390-ccw/main.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
index 7509755e36..76bf743900 100644
--- a/pc-bios/s390-ccw/main.c
+++ b/pc-bios/s390-ccw/main.c
@@ -191,7 +191,7 @@ static void boot_setup(void)
 {
     char lpmsg[] = "LOADPARM=[________]\n";
 
-    if (memcmp(iplb.loadparm, NO_LOADPARM, LOADPARM_LEN) != 0) {
+    if (have_iplb && memcmp(iplb.loadparm, NO_LOADPARM, LOADPARM_LEN) != 0) {
         ebcdic_to_ascii((char *) iplb.loadparm, loadparm_str, LOADPARM_LEN);
     } else {
         sclp_get_loadparm_ascii(loadparm_str);
@@ -316,6 +316,7 @@ void main(void)
     css_setup();
     have_iplb = store_iplb(&iplb);
     if (!have_iplb) {
+        boot_setup();
         probe_boot_device();
     }