summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorFiona Ebner <f.ebner@proxmox.com>2024-01-23 14:50:44 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2024-01-30 16:13:28 -0500
commit75e79f5a08c9d6a573bace48403799fd432b5dbd (patch)
treea7fd1ee80bc77efc8e107eb201d1a7f37bd732d0
parent11be70677c70fdccd452a3233653949b79e97908 (diff)
downloadfocaccia-qemu-75e79f5a08c9d6a573bace48403799fd432b5dbd.tar.gz
focaccia-qemu-75e79f5a08c9d6a573bace48403799fd432b5dbd.zip
block/io_uring: improve error message when init fails
The man page for io_uring_queue_init states:

> io_uring_queue_init(3) returns 0 on success and -errno on failure.

and the man page for io_uring_setup (which is one of the functions
where the return value of io_uring_queue_init() can come from) states:

> On error, a negative error code is returned. The caller should not
> rely on errno variable.

Tested using 'sysctl kernel.io_uring_disabled=2'. Output before this
change:

> failed to init linux io_uring ring

Output after this change:

> failed to init linux io_uring ring: Operation not permitted

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240123135044.204985-1-f.ebner@proxmox.com>
Diffstat (limited to '')
-rw-r--r--block/io_uring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/io_uring.c b/block/io_uring.c
index d77ae55745..d11b2051ab 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -432,7 +432,7 @@ LuringState *luring_init(Error **errp)
 
     rc = io_uring_queue_init(MAX_ENTRIES, ring, 0);
     if (rc < 0) {
-        error_setg_errno(errp, errno, "failed to init linux io_uring ring");
+        error_setg_errno(errp, -rc, "failed to init linux io_uring ring");
         g_free(s);
         return NULL;
     }