summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2021-02-24 13:14:35 +0800
committerJason Wang <jasowang@redhat.com>2021-03-15 16:41:22 +0800
commit8c92060d3c0248bd4d515719a35922cd2391b9b4 (patch)
tree3baff0d2569343e238e12241dcb92708c7a45f8c
parent26194a58f4eb83c5bdf4061a1628508084450ba1 (diff)
downloadfocaccia-qemu-8c92060d3c0248bd4d515719a35922cd2391b9b4.tar.gz
focaccia-qemu-8c92060d3c0248bd4d515719a35922cd2391b9b4.zip
sungem: switch to use qemu_receive_packet() for loopback
This patch switches to use qemu_receive_packet() which can detect
reentrancy and return early.

This is intended to address CVE-2021-3416.

Cc: Prasad J Pandit <ppandit@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
-rw-r--r--hw/net/sungem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/net/sungem.c b/hw/net/sungem.c
index 33c3722df6..3684a4d733 100644
--- a/hw/net/sungem.c
+++ b/hw/net/sungem.c
@@ -306,7 +306,7 @@ static void sungem_send_packet(SunGEMState *s, const uint8_t *buf,
     NetClientState *nc = qemu_get_queue(s->nic);
 
     if (s->macregs[MAC_XIFCFG >> 2] & MAC_XIFCFG_LBCK) {
-        nc->info->receive(nc, buf, size);
+        qemu_receive_packet(nc, buf, size);
     } else {
         qemu_send_packet(nc, buf, size);
     }