diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2024-08-15 14:12:06 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2024-09-19 13:13:58 +0100 |
| commit | c4d16d4168862735d746dd5d9e579cfc45c5e123 (patch) | |
| tree | 4ac59fa4134cff653ccbde24f6a3bef5948c6767 | |
| parent | 28d2d03c9c221b204707186dd819fe7407377d12 (diff) | |
| download | focaccia-qemu-c4d16d4168862735d746dd5d9e579cfc45c5e123.tar.gz focaccia-qemu-c4d16d4168862735d746dd5d9e579cfc45c5e123.zip | |
kvm: Remove unreachable code in kvm_dirty_ring_reaper_thread()
The code at the tail end of the loop in kvm_dirty_ring_reaper_thread() is unreachable, because there is no way for execution to leave the loop. Replace it with a g_assert_not_reached(). (The code has always been unreachable, right from the start when the function was added in commit b4420f198dd8.) Resolves: Coverity CID 1547687 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-id: 20240815131206.3231819-3-peter.maydell@linaro.org
| -rw-r--r-- | accel/kvm/kvm-all.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 6c4cb263ba..fe4cd721d9 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -1525,11 +1525,7 @@ static void *kvm_dirty_ring_reaper_thread(void *data) r->reaper_iteration++; } - trace_kvm_dirty_ring_reaper("exit"); - - rcu_unregister_thread(); - - return NULL; + g_assert_not_reached(); } static void kvm_dirty_ring_reaper_init(KVMState *s) |