summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPeter Xu <peterx@redhat.com>2017-07-05 16:21:23 +0800
committerDr. David Alan Gilbert <dgilbert@redhat.com>2017-07-10 17:52:21 +0100
commitc8d3ff384f14634fde1c3ea6bcdcd7e06c29df29 (patch)
tree916f1d72cab6094b3cc02419e35be0ac9fb38d94
parent16f7244842b5135543ef068a1adafd94c6965953 (diff)
downloadfocaccia-qemu-c8d3ff384f14634fde1c3ea6bcdcd7e06c29df29.tar.gz
focaccia-qemu-c8d3ff384f14634fde1c3ea6bcdcd7e06c29df29.zip
doc: update TYPE_MIGRATION documents
[Peter collected Eduardo's patch comment and formatted into patch]

Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1499242883-2184-5-git-send-email-peterx@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
-rw-r--r--migration/migration.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/migration/migration.c b/migration/migration.c
index dbdc121838..31d46d1343 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2052,12 +2052,12 @@ static void migration_instance_init(Object *obj)
 static const TypeInfo migration_type = {
     .name = TYPE_MIGRATION,
     /*
-     * NOTE: "migration" itself is not really a device. We used
-     * TYPE_DEVICE here only to leverage some existing QDev features
-     * like "-global" properties, and HW_COMPAT_* fields (which are
-     * finally applied as global properties as well). If one day the
-     * global property feature can be migrated from QDev to QObject in
-     * general, then we can switch to QObject as well.
+     * NOTE: TYPE_MIGRATION is not really a device, as the object is
+     * not created using qdev_create(), it is not attached to the qdev
+     * device tree, and it is never realized.
+     *
+     * TODO: Make this TYPE_OBJECT once QOM provides something like
+     * TYPE_DEVICE's "-global" properties.
      */
     .parent = TYPE_DEVICE,
     .class_init = migration_class_init,