diff options
| author | Greg Kurz <groug@kaod.org> | 2021-10-15 11:29:44 +0200 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2021-10-23 18:50:19 +0200 |
| commit | f18d403f15b92ded56362703067eb67161cfe2a9 (patch) | |
| tree | 786cc14b60c96485397d34dc90cf7760b7bb88ff | |
| parent | 3bc1bb80423b789cabedde2813630dd5092cb24a (diff) | |
| download | focaccia-qemu-f18d403f15b92ded56362703067eb67161cfe2a9.tar.gz focaccia-qemu-f18d403f15b92ded56362703067eb67161cfe2a9.zip | |
softmmu/physmem.c: Fix typo in comment
Fix the comment to match what the code is doing, as explained in
the changelog of commit 86cf9e154632cb28d749db0ea47946fba8cf3f09
that introduced the change:
Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization
of vCPU and migration operations through calling run_on_cpu operation.
However, in replay mode this synchronization is unneeded, because
I/O and vCPU threads are already synchronized.
This patch disables such synchronization for record/replay mode.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <163429018454.1146856.3429437540871060739.stgit@bahia.huguette>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | softmmu/physmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/softmmu/physmem.c b/softmmu/physmem.c index f67ad29981..555c907f67 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener) * In record/replay mode this causes a deadlock, because * run_on_cpu waits for rr mutex. Therefore no races are possible * in this case and no need for making run_on_cpu when - * record/replay is not enabled. + * record/replay is enabled. */ cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener); run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL); |