summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorJason Baron <jbaron@redhat.com>2012-09-04 16:22:46 -0400
committerMichael S. Tsirkin <mst@redhat.com>2012-09-07 09:02:44 +0300
commit0e180d9c8a7429c55d23d2e7855f1e490a063aaa (patch)
tree4b2bff032a935ec9964d9d6af8991684bc14f5b0
parent1de53459272d89c52bb21b45d5d970de40fbb642 (diff)
downloadfocaccia-qemu-0e180d9c8a7429c55d23d2e7855f1e490a063aaa.tar.gz
focaccia-qemu-0e180d9c8a7429c55d23d2e7855f1e490a063aaa.zip
pcie_aer: clear cmask for Advanced Error Interrupt Message Number
The Advanced Error Interrupt Message Number (bits 31:27 of the Root
Error Status Register) is updated when the number of msi messages assigned to a
device changes. Migration of windows 7 on q35 chipset failed because the check
in get_pci_config_device() fails due to cmask being set on these bits. Its valid
to update these bits and we must restore this state across migration.

Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/pcie_aer.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c
index 3b6981c7b7..b04c164e22 100644
--- a/hw/pcie_aer.c
+++ b/hw/pcie_aer.c
@@ -738,6 +738,11 @@ void pcie_aer_root_init(PCIDevice *dev)
                  PCI_ERR_ROOT_CMD_EN_MASK);
     pci_set_long(dev->w1cmask + pos + PCI_ERR_ROOT_STATUS,
                  PCI_ERR_ROOT_STATUS_REPORT_MASK);
+    /* PCI_ERR_ROOT_IRQ is RO but devices change it using a
+     * device-specific method.
+     */
+    pci_set_long(dev->cmask + pos + PCI_ERR_ROOT_STATUS,
+                 ~PCI_ERR_ROOT_IRQ);
 }
 
 void pcie_aer_root_reset(PCIDevice *dev)