summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2023-06-06 11:46:09 +0100
committerPeter Maydell <peter.maydell@linaro.org>2023-06-19 11:24:21 +0100
commit22c81783c9458f2b41d554e0172c9d0fcf6da4cc (patch)
tree1de33e40222c37b53182fe70240f0ca438040998
parentf837b468cdaa7e736b5385c7dc4f8c5adcad3bf1 (diff)
downloadfocaccia-qemu-22c81783c9458f2b41d554e0172c9d0fcf6da4cc.tar.gz
focaccia-qemu-22c81783c9458f2b41d554e0172c9d0fcf6da4cc.zip
hw/sd/allwinner-sdhost: Don't send non-boolean IRQ line levels
QEMU allows qemu_irq lines to transfer arbitrary integers.  However
the convention is that for a simple IRQ line the values transferred
are always 0 and 1.  The A10 SD controller device instead assumes a
0-vs-non-0 convention, which happens to work with the interrupt
controller it is wired up to.

Coerce the value to boolean to follow our usual convention.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Message-id: 20230606104609.3692557-3-peter.maydell@linaro.org
-rw-r--r--hw/sd/allwinner-sdhost.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/sd/allwinner-sdhost.c b/hw/sd/allwinner-sdhost.c
index 286e009509..1a576d62ae 100644
--- a/hw/sd/allwinner-sdhost.c
+++ b/hw/sd/allwinner-sdhost.c
@@ -193,7 +193,7 @@ static void allwinner_sdhost_update_irq(AwSdHostState *s)
     }
 
     trace_allwinner_sdhost_update_irq(irq);
-    qemu_set_irq(s->irq, irq);
+    qemu_set_irq(s->irq, !!irq);
 }
 
 static void allwinner_sdhost_update_transfer_cnt(AwSdHostState *s,