diff options
| author | Max Reitz <mreitz@redhat.com> | 2017-11-15 00:22:23 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2017-11-15 09:34:51 +0100 |
| commit | 26a5db322be1e424a815d070ddd04442a5e5df50 (patch) | |
| tree | 2aed346650edf5433c961a2910966aaf62d2fb70 | |
| parent | 17b50b0c299f1266578b01f7134810362418ac2e (diff) | |
| download | focaccia-qemu-26a5db322be1e424a815d070ddd04442a5e5df50.tar.gz focaccia-qemu-26a5db322be1e424a815d070ddd04442a5e5df50.zip | |
util/stats64: Fix min/max comparisons
stat64_min_slow() and stat64_max_slow() compare the wrong way. This makes iotest 136 fail with clang and -m32. Signed-off-by: Max Reitz <mreitz@redhat.com> Message-Id: <20171114232223.25207-1-mreitz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | util/stats64.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/stats64.c b/util/stats64.c index 9968fcceac..389c365a9e 100644 --- a/util/stats64.c +++ b/util/stats64.c @@ -91,7 +91,7 @@ bool stat64_min_slow(Stat64 *s, uint64_t value) low = atomic_read(&s->low); orig = ((uint64_t)high << 32) | low; - if (orig < value) { + if (value < orig) { /* We have to set low before high, just like stat64_min reads * high before low. The value may become higher temporarily, but * stat64_get does not notice (it takes the lock) and the only ill @@ -120,7 +120,7 @@ bool stat64_max_slow(Stat64 *s, uint64_t value) low = atomic_read(&s->low); orig = ((uint64_t)high << 32) | low; - if (orig > value) { + if (value > orig) { /* We have to set low before high, just like stat64_max reads * high before low. The value may become lower temporarily, but * stat64_get does not notice (it takes the lock) and the only ill |