summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorLi Zhijian <lizhijian@fujitsu.com>2024-05-16 11:45:17 +0800
committerFabiano Rosas <farosas@suse.de>2024-05-22 17:34:36 -0300
commit3dc27fac2547623d837826bbda5369d7b240c78e (patch)
treedeea48ab22173a684ed1ba85eb0ccfe208e40109
parent787ea49e80df0e7af922586f6076da94410cdd08 (diff)
downloadfocaccia-qemu-3dc27fac2547623d837826bbda5369d7b240c78e.tar.gz
focaccia-qemu-3dc27fac2547623d837826bbda5369d7b240c78e.zip
migration/colo: Tidy up bql_unlock() around bdrv_activate_all()
Make the code more tight.

Suggested-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
[fixed mangled author email address]
Signed-off-by: Fabiano Rosas <farosas@suse.de>
-rw-r--r--migration/colo.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/migration/colo.c b/migration/colo.c
index ca37b932ac..f96c2ee069 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -837,12 +837,11 @@ static void *colo_process_incoming_thread(void *opaque)
     /* Make sure all file formats throw away their mutable metadata */
     bql_lock();
     bdrv_activate_all(&local_err);
+    bql_unlock();
     if (local_err) {
-        bql_unlock();
         error_report_err(local_err);
         return NULL;
     }
-    bql_unlock();
 
     failover_init_state();