diff options
| author | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2011-06-01 12:35:14 +0530 |
|---|---|---|
| committer | Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com> | 2011-06-01 10:25:27 -0700 |
| commit | 5c3234c6c037943bd4c2d643a1b8cc35f563dbdb (patch) | |
| tree | d0db67b8f4f3bdb5a77d96be1ed949373d162674 | |
| parent | faa44e3d3e986f29579e0d0d07b7aef771184e8c (diff) | |
| download | focaccia-qemu-5c3234c6c037943bd4c2d643a1b8cc35f563dbdb.tar.gz focaccia-qemu-5c3234c6c037943bd4c2d643a1b8cc35f563dbdb.zip | |
hw/9pfs: Don't crash when we get a request with not supported 9p operation
Return EOPNOTSUPP as error Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Signed-off-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
| -rw-r--r-- | hw/9pfs/virtio-9p.c | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index ec97b10f49..ed081393a9 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -3606,6 +3606,11 @@ static pdu_handler_t *pdu_handlers[] = { [P9_TREMOVE] = v9fs_remove, }; +static void v9fs_op_not_supp(V9fsState *s, V9fsPDU *pdu) +{ + complete_pdu(s, pdu, -EOPNOTSUPP); +} + static void submit_pdu(V9fsState *s, V9fsPDU *pdu) { pdu_handler_t *handler; @@ -3613,12 +3618,12 @@ static void submit_pdu(V9fsState *s, V9fsPDU *pdu) if (debug_9p_pdu) { pprint_pdu(pdu); } - - BUG_ON(pdu->id >= ARRAY_SIZE(pdu_handlers)); - - handler = pdu_handlers[pdu->id]; - BUG_ON(handler == NULL); - + if (pdu->id >= ARRAY_SIZE(pdu_handlers) || + (pdu_handlers[pdu->id] == NULL)) { + handler = v9fs_op_not_supp; + } else { + handler = pdu_handlers[pdu->id]; + } handler(s, pdu); } |