summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2024-07-31 16:41:35 +0100
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2024-08-06 16:23:46 +0200
commit7aea035a60eec599c487d71659fdb5102b69cfb9 (patch)
tree3a9dc1ba38f5b4329b1e1c79ee9d91914a4323ec
parent0fa57cbfa7039e4a579f1a4a0956982b654335c8 (diff)
downloadfocaccia-qemu-7aea035a60eec599c487d71659fdb5102b69cfb9.tar.gz
focaccia-qemu-7aea035a60eec599c487d71659fdb5102b69cfb9.zip
system/vl.c: Expand OpenGL related errors
Expand the OpenGL related error messages we produce for various
"OpenGL not present/not supported" cases, to hopefully guide the
user towards how to fix things.

Now if the user tries to enable GL on a backend that doesn't
support it the error message is a bit more precise:

$ qemu-system-aarch64 -M virt -device virtio-gpu-gl -display curses,gl=on
qemu-system-aarch64: OpenGL is not supported by display backend 'curses'

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[AJB: Improved error report message]
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-ID: <20240731154136.3494621-3-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-rw-r--r--system/vl.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/system/vl.c b/system/vl.c
index 9e8f16f155..41d53d2456 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -1973,9 +1973,10 @@ static void qemu_create_early_backends(void)
 
     if (dpy.has_gl && dpy.gl != DISPLAYGL_MODE_OFF && display_opengl == 0) {
 #if defined(CONFIG_OPENGL)
-        error_report("OpenGL is not supported by the display");
+        error_report("OpenGL is not supported by display backend '%s'",
+                     DisplayType_str(dpy.type));
 #else
-        error_report("OpenGL support is disabled");
+        error_report("OpenGL support was not enabled in this build of QEMU");
 #endif
         exit(1);
     }