summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorHavard Skinnemoen <hskinnemoen@google.com>2020-11-02 17:14:55 -0800
committerPeter Maydell <peter.maydell@linaro.org>2020-11-10 11:03:48 +0000
commit8006c9842bf6f52fdcfb1c8f64c9bd714e661301 (patch)
tree4f4a322bf4aaca345860b4b02af5d6fd0bbc1321
parent0e5dc775736fda574e0df9c4c9a29c92201833fe (diff)
downloadfocaccia-qemu-8006c9842bf6f52fdcfb1c8f64c9bd714e661301.tar.gz
focaccia-qemu-8006c9842bf6f52fdcfb1c8f64c9bd714e661301.zip
tests/qtest/npcm7xx_rng-test: count runs properly
The number of runs is equal to the number of 0-1 and 1-0 transitions,
plus one. Currently, it's counting the number of times these transitions
do _not_ happen, plus one.

Source:
https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-22r1a.pdf
section 2.3.4 point (3).

Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
Message-id: 20201103011457.2959989-2-hskinnemoen@google.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-rw-r--r--tests/qtest/npcm7xx_rng-test.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qtest/npcm7xx_rng-test.c b/tests/qtest/npcm7xx_rng-test.c
index e7cde85fbb..c614968ffc 100644
--- a/tests/qtest/npcm7xx_rng-test.c
+++ b/tests/qtest/npcm7xx_rng-test.c
@@ -126,7 +126,7 @@ static double calc_runs_p(const unsigned long *buf, unsigned int nr_bits)
     pi = (double)nr_ones / nr_bits;
 
     for (k = 0; k < nr_bits - 1; k++) {
-        vn_obs += !(test_bit(k, buf) ^ test_bit(k + 1, buf));
+        vn_obs += (test_bit(k, buf) ^ test_bit(k + 1, buf));
     }
     vn_obs += 1;