summary refs log tree commit diff stats
diff options
context:
space:
mode:
authorChen Qun <kuhn.chenqun@huawei.com>2020-12-11 16:24:23 +0100
committerThomas Huth <thuth@redhat.com>2020-12-18 09:14:23 +0100
commit9cf5a9cf60a3c5271dee05b6a81a05fb45bee622 (patch)
treefe3f0952e1e0dc70f81afc4d6d9744cb4fcd7705
parentfc0cd867819a5cff9dd49b2fca4d927d765aa7ae (diff)
downloadfocaccia-qemu-9cf5a9cf60a3c5271dee05b6a81a05fb45bee622.tar.gz
focaccia-qemu-9cf5a9cf60a3c5271dee05b6a81a05fb45bee622.zip
target/sparc/win_helper: silence the compiler warnings
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
target/sparc/win_helper.c: In function ‘get_gregset’:
target/sparc/win_helper.c:304:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
  304 |         trace_win_helper_gregset_error(pstate);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
target/sparc/win_helper.c:306:5: note: here
  306 |     case 0:
      |     ^~~~

Add the corresponding "fall through" comment to fix it.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Artyom Tarasenko <atar4qemu@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201211152426.350966-10-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
-rw-r--r--target/sparc/win_helper.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/sparc/win_helper.c b/target/sparc/win_helper.c
index 5b57892a10..3a7c0ff943 100644
--- a/target/sparc/win_helper.c
+++ b/target/sparc/win_helper.c
@@ -302,7 +302,7 @@ static inline uint64_t *get_gregset(CPUSPARCState *env, uint32_t pstate)
     switch (pstate) {
     default:
         trace_win_helper_gregset_error(pstate);
-        /* pass through to normal set of global registers */
+        /* fall through to normal set of global registers */
     case 0:
         return env->bgregs;
     case PS_AG: