diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2021-08-26 19:26:57 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2021-09-04 17:34:05 -0400 |
| commit | b116d6c319661b59d0461f771f407e47f54a8c80 (patch) | |
| tree | 6ea21f56e87dda81b4b31cdfe6dee1b8eaf6f99c | |
| parent | 7f51beddadbc7d879a4f0979c1cf330f7010161a (diff) | |
| download | focaccia-qemu-b116d6c319661b59d0461f771f407e47f54a8c80.tar.gz focaccia-qemu-b116d6c319661b59d0461f771f407e47f54a8c80.zip | |
hw/virtio: Remove NULL check in virtio_free_region_cache()
virtio_free_region_cache() is called within call_rcu(), always with a non-NULL argument. Ensure new code keep it that way by replacing the NULL check by an assertion. Add a comment this function is called within call_rcu(). Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20210826172658.2116840-3-philmd@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | hw/virtio/virtio.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index a5214bca61..3a1f6c520c 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -133,12 +133,10 @@ struct VirtQueue QLIST_ENTRY(VirtQueue) node; }; +/* Called within call_rcu(). */ static void virtio_free_region_cache(VRingMemoryRegionCaches *caches) { - if (!caches) { - return; - } - + assert(caches != NULL); address_space_cache_destroy(&caches->desc); address_space_cache_destroy(&caches->avail); address_space_cache_destroy(&caches->used); |