diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-03-11 18:55:24 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-03-22 22:20:18 +0100 |
| commit | b6572b4f97a7b126c7b24e165893ed9fe3d72e1f (patch) | |
| tree | ebb46243454c8decd94f1058115ffc5c9ebcedb0 | |
| parent | 5c3ece79cd0b7b4ed065f4285e7a0262bbfc283b (diff) | |
| download | focaccia-qemu-b6572b4f97a7b126c7b24e165893ed9fe3d72e1f.tar.gz focaccia-qemu-b6572b4f97a7b126c7b24e165893ed9fe3d72e1f.zip | |
char: translate from QIOChannel error to errno
Caller of CharDriverState.chr* callback assume errno error conventions. Translate QIOChannel error to errno (this fixes potential EAGAIN regression, for ex if a vhost-user backend block, qemu_chr_fe_read_all() could get error -2 and not wait) Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <1457718924-19338-1-git-send-email-marcandre.lureau@redhat.com> Reviewed-by: Daniel P. Berrange <berrange@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | qemu-char.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/qemu-char.c b/qemu-char.c index 97aaaae439..270819aec3 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2799,6 +2799,13 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf, size_t len) NULL); } + if (ret == QIO_CHANNEL_ERR_BLOCK) { + errno = EAGAIN; + ret = -1; + } else if (ret == -1) { + errno = EIO; + } + if (msgfds_num) { /* close and clean read_msgfds */ for (i = 0; i < s->read_msgfds_num; i++) { |