diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2024-02-14 04:18:01 +0000 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2024-02-29 11:35:37 -1000 |
| commit | b816e1b5ba58a986b10cd830d6617f351979ab91 (patch) | |
| tree | c1a015991fff805bc2bb23c469865b8129241a40 | |
| parent | f2ffdfab7e5ae5217567508bb74c329e3b19dd44 (diff) | |
| download | focaccia-qemu-b816e1b5ba58a986b10cd830d6617f351979ab91.tar.gz focaccia-qemu-b816e1b5ba58a986b10cd830d6617f351979ab91.zip | |
linux-user: Remove pgb_dynamic alignment assertion
The assertion was never correct, because the alignment is a composite
of the image alignment and SHMLBA. Even if the image alignment didn't
match the image address, an assertion would not be correct -- more
appropriate would be an error message about an ill formed image. But
the image cannot be held to SHMLBA under any circumstances.
Fixes: ee94743034b ("linux-user: completely re-write init_guest_space")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2157
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reported-by: Alexey Sheplyakov <asheplyakov@yandex.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | linux-user/elfload.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/linux-user/elfload.c b/linux-user/elfload.c index cc2013c7b4..0c299a7c15 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -3022,8 +3022,6 @@ static void pgb_dynamic(const char *image_name, uintptr_t guest_loaddr, uintptr_t brk, ret; PGBAddrs ga; - assert(QEMU_IS_ALIGNED(guest_loaddr, align)); - /* Try the identity map first. */ if (pgb_addr_set(&ga, guest_loaddr, guest_hiaddr, true)) { brk = (uintptr_t)sbrk(0); |