diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2025-04-01 16:43:32 +0200 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2025-04-03 15:57:37 -0700 |
| commit | e139bc4b1772575e1f2dcf8e3dbe1df2b684ef1f (patch) | |
| tree | 32a1523df79705b0bf8e8d2ef3dec4fe9b3ee962 | |
| parent | 0adf626718bc0ca9c46550249a76047f8e45da15 (diff) | |
| download | focaccia-qemu-e139bc4b1772575e1f2dcf8e3dbe1df2b684ef1f.tar.gz focaccia-qemu-e139bc4b1772575e1f2dcf8e3dbe1df2b684ef1f.zip | |
tcg: Allocate TEMP_VAL_MEM frame in temp_load()
Be sure to allocate the temp frame if it wasn't.
In the resolved issues, incomplete dead code elimination left a load
at the top of an unreachable loop. We simply need to allocate the
stack slot to avoid crashing.
Fixes: c896fe29d6c ("TCG code generator")
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Reported-by: Helge Konetzka <hk@zapateado.de>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2891
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2899
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250401144332.41615-1-philmd@linaro.org>
| -rw-r--r-- | tcg/tcg.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tcg/tcg.c b/tcg/tcg.c index e8950df2ad..dfd48b8264 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -4671,6 +4671,9 @@ static void temp_load(TCGContext *s, TCGTemp *ts, TCGRegSet desired_regs, ts->mem_coherent = 0; break; case TEMP_VAL_MEM: + if (!ts->mem_allocated) { + temp_allocate_frame(s, ts); + } reg = tcg_reg_alloc(s, desired_regs, allocated_regs, preferred_regs, ts->indirect_base); tcg_out_ld(s, ts->type, reg, ts->mem_base->reg, ts->mem_offset); |