summary refs log tree commit diff stats
path: root/backends/tpm/tpm_emulator.c
diff options
context:
space:
mode:
authorSteve Sistare <steven.sistare@oracle.com>2024-01-03 12:05:32 -0800
committerPeter Xu <peterx@redhat.com>2024-01-04 09:52:42 +0800
commit0f1db069b6c5e7f7ddcdcc9c64fd4b6dbe4afcdf (patch)
tree4d3d938503ae964c4551e2a8b57f2b7e84427826 /backends/tpm/tpm_emulator.c
parentb9ae473d80302519a7b89f98795a80abfea1deea (diff)
downloadfocaccia-qemu-0f1db069b6c5e7f7ddcdcc9c64fd4b6dbe4afcdf.tar.gz
focaccia-qemu-0f1db069b6c5e7f7ddcdcc9c64fd4b6dbe4afcdf.zip
cpus: check running not RUN_STATE_RUNNING
When a vm transitions from running to suspended, runstate notifiers are
not called, so the notifiers still think the vm is running.  Hence, when
we call vm_start to restore the suspended state, we call vm_state_notify
with running=1.  However, some notifiers check for RUN_STATE_RUNNING.
They must check the running boolean instead.

No functional change.

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/1704312341-66640-4-git-send-email-steven.sistare@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'backends/tpm/tpm_emulator.c')
-rw-r--r--backends/tpm/tpm_emulator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c
index f7f1b4ad7a..254fce7764 100644
--- a/backends/tpm/tpm_emulator.c
+++ b/backends/tpm/tpm_emulator.c
@@ -904,7 +904,7 @@ static void tpm_emulator_vm_state_change(void *opaque, bool running,
 
     trace_tpm_emulator_vm_state_change(running, state);
 
-    if (!running || state != RUN_STATE_RUNNING || !tpm_emu->relock_storage) {
+    if (!running || !tpm_emu->relock_storage) {
         return;
     }