diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2018-05-24 15:26:10 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2018-05-30 13:31:01 +0200 |
| commit | 1266c9b9f5fa05877b979eece5963a2bd99c3bfd (patch) | |
| tree | 348fa8501283cccf4a62ace8e262ca6bef6c1939 /block/commit.c | |
| parent | 4a5f2779bad769184550869931937acd0707ec3b (diff) | |
| download | focaccia-qemu-1266c9b9f5fa05877b979eece5963a2bd99c3bfd.tar.gz focaccia-qemu-1266c9b9f5fa05877b979eece5963a2bd99c3bfd.zip | |
job: Add error message for failing jobs
So far we relied on job->ret and strerror() to produce an error message for failed jobs. Not surprisingly, this tends to result in completely useless messages. This adds a Job.error field that can contain an error string for a failing job, and a parameter to job_completed() that sets the field. As a default, if NULL is passed, we continue to use strerror(job->ret). All existing callers are changed to pass NULL. They can be improved in separate patches. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'block/commit.c')
| -rw-r--r-- | block/commit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/commit.c b/block/commit.c index 620666161b..e1814d9693 100644 --- a/block/commit.c +++ b/block/commit.c @@ -117,7 +117,7 @@ static void commit_complete(Job *job, void *opaque) * bdrv_set_backing_hd() to fail. */ block_job_remove_all_bdrv(bjob); - job_completed(job, ret); + job_completed(job, ret, NULL); g_free(data); /* If bdrv_drop_intermediate() didn't already do that, remove the commit |