summary refs log tree commit diff stats
path: root/chardev/char-socket.c
diff options
context:
space:
mode:
authorJulia Suvorova <jusual@redhat.com>2020-06-04 14:59:46 +0200
committerMichael S. Tsirkin <mst@redhat.com>2020-06-09 14:18:04 -0400
commit0dabc0f6544f2c0310546f6d6cf3b68979580a9c (patch)
tree1e0d7c3c2e3325e4a10d1b519aae62ef7829fbbd /chardev/char-socket.c
parentb963ea19f896e34e21275ff69fa4565948f703c8 (diff)
downloadfocaccia-qemu-0dabc0f6544f2c0310546f6d6cf3b68979580a9c.tar.gz
focaccia-qemu-0dabc0f6544f2c0310546f6d6cf3b68979580a9c.zip
hw/pci/pcie: Move hot plug capability check to pre_plug callback
Check for hot plug capability earlier to avoid removing devices attached
during the initialization process.

Run qemu with an unattached drive:
  -drive file=$FILE,if=none,id=drive0 \
  -device pcie-root-port,id=rp0,slot=3,bus=pcie.0,hotplug=off
Hotplug a block device:
  device_add virtio-blk-pci,id=blk0,drive=drive0,bus=rp0
If hotplug fails on plug_cb, drive0 will be deleted.

Fixes: 0501e1aa1d32a6 ("hw/pci/pcie: Forbid hot-plug if it's disabled on the slot")

Acked-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Message-Id: <20200604125947.881210-1-jusual@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'chardev/char-socket.c')
0 files changed, 0 insertions, 0 deletions