diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2023-03-02 18:57:49 -0800 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2023-03-07 20:44:08 +0000 |
| commit | a7e0f9bd2ace16df2aa557b0670c20bfe9cef280 (patch) | |
| tree | e5a4475e780edf11cafa7c340376bf91b914586f /gdbstub/gdbstub.c | |
| parent | ccd4c7c24a722288127eff2a4dc2793e6a3c04f0 (diff) | |
| download | focaccia-qemu-a7e0f9bd2ace16df2aa557b0670c20bfe9cef280.tar.gz focaccia-qemu-a7e0f9bd2ace16df2aa557b0670c20bfe9cef280.zip | |
gdbstub: abstract target specific details from gdb_put_packet_binary
We unfortunately handle the checking of packet acknowledgement differently for user and softmmu modes. Abstract the user mode stuff behind gdb_got_immediate_ack with a stub for softmmu. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Message-Id: <20230302190846.2593720-14-alex.bennee@linaro.org> Message-Id: <20230303025805.625589-14-richard.henderson@linaro.org>
Diffstat (limited to 'gdbstub/gdbstub.c')
| -rw-r--r-- | gdbstub/gdbstub.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6907bdc99c..0476ee7039 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -239,15 +239,9 @@ int gdb_put_packet_binary(const char *buf, int len, bool dump) gdb_put_buffer(gdbserver_state.last_packet->data, gdbserver_state.last_packet->len); -#ifdef CONFIG_USER_ONLY - i = gdb_get_char(); - if (i < 0) - return -1; - if (i == '+') + if (gdb_got_immediate_ack()) { break; -#else - break; -#endif + } } return 0; } |