diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2010-11-05 16:01:29 -0600 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-11-16 09:31:18 -0600 |
| commit | b538e53ee7e8b9e2920d3286b480276cef209fd4 (patch) | |
| tree | 75fa15ef85234efa3cab5e0c4f7cd5ffdfd7bb9b /hw/apic.c | |
| parent | 4cff0a5994d0300e6e77e90d3354aa517a120539 (diff) | |
| download | focaccia-qemu-b538e53ee7e8b9e2920d3286b480276cef209fd4.tar.gz focaccia-qemu-b538e53ee7e8b9e2920d3286b480276cef209fd4.zip | |
apic: Don't iterate past last used apic
local_apics are allocated sequentially and never removed, so we can stop any iterations that go to MAX_APICS as soon as we hit the first NULL. Looking at a small guest running a virtio-net workload with oprofile, this drops apic_get_delivery_bitmask() from #3 in the profile to down in the noise. Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/apic.c')
| -rw-r--r-- | hw/apic.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/apic.c b/hw/apic.c index 63d62c7553..5f4a87c807 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -437,6 +437,8 @@ static int apic_find_dest(uint8_t dest) apic = local_apics[i]; if (apic && apic->id == dest) return i; + if (!apic) + break; } return -1; @@ -472,6 +474,8 @@ static void apic_get_delivery_bitmask(uint32_t *deliver_bitmask, set_bit(deliver_bitmask, i); } } + } else { + break; } } } |