summary refs log tree commit diff stats
path: root/hw/arm/netduino2.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-12-17 17:35:20 +0100
committerMarkus Armbruster <armbru@redhat.com>2016-01-13 15:16:16 +0100
commit7e274652e4e2225298a2735c3dcc74f2f8ba7b07 (patch)
tree4e40fcbf90fe3412d1de696ca6760ba7f6bff853 /hw/arm/netduino2.c
parent675463d9b6b2c2b65a713a6d906aeebe9e6750ae (diff)
downloadfocaccia-qemu-7e274652e4e2225298a2735c3dcc74f2f8ba7b07.tar.gz
focaccia-qemu-7e274652e4e2225298a2735c3dcc74f2f8ba7b07.zip
audio: Clean up inappropriate and unreachable use of hw_error()
audio_init() should not use hw_error(), because dumping CPU registers
is unhelpful there, and aborting is wrong, because it can be called
called from an audio device's realize() method.

The two uses of hw_error() come from commit 0d9acba:

* When qemu_new_timer() fails.  It couldn't fail back then, and it
  can't fail now.  Drop the unreachable error handling.

* When no_audio_driver can't be initialized.  It couldn't fail back
  then, and it can't fail now.  Replace the error handling by an
  assertion.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/arm/netduino2.c')
0 files changed, 0 insertions, 0 deletions