diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2011-06-01 13:29:11 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2011-07-23 11:18:57 -0500 |
| commit | 6e1db57b2ac9025c2443c665a0d9e78748637b26 (patch) | |
| tree | cb4b73d71dccfc14737c713b07ee3bf89a3c0cf2 /hw/baum.c | |
| parent | 84682834eb8f654da5e03a92930d80b8ae0d3065 (diff) | |
| download | focaccia-qemu-6e1db57b2ac9025c2443c665a0d9e78748637b26.tar.gz focaccia-qemu-6e1db57b2ac9025c2443c665a0d9e78748637b26.zip | |
qemu-char: Print strerror message on failure
The only way for chardev drivers to communicate an error was to return a NULL pointer, which resulted in an error message that said _that_ something went wrong, but not _why_. This patch changes the interface to return 0/-errno and updates qemu_chr_open_opts to use strerror to display a more helpful error message. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/baum.c')
| -rw-r--r-- | hw/baum.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/hw/baum.c b/hw/baum.c index 2aaf5ffe9d..33a22a73d9 100644 --- a/hw/baum.c +++ b/hw/baum.c @@ -576,7 +576,7 @@ static void baum_close(struct CharDriverState *chr) qemu_free(baum); } -CharDriverState *chr_baum_init(QemuOpts *opts) +int chr_baum_init(QemuOpts *opts, CharDriverState **_chr) { BaumDriverState *baum; CharDriverState *chr; @@ -629,7 +629,8 @@ CharDriverState *chr_baum_init(QemuOpts *opts) qemu_chr_generic_open(chr); - return chr; + *_chr = chr; + return 0; fail: qemu_free_timer(baum->cellCount_timer); @@ -638,5 +639,5 @@ fail_handle: qemu_free(handle); qemu_free(chr); qemu_free(baum); - return NULL; + return -EIO; } |