summary refs log tree commit diff stats
path: root/hw/core/machine-hmp-cmds.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2020-04-24 10:43:33 +0200
committerMarkus Armbruster <armbru@redhat.com>2020-04-30 07:26:40 +0200
commitc978bd5226f1ed73456ac468a7ed50af3d24dc84 (patch)
tree0a375411a70f63073f52ce209d26324511b41896 /hw/core/machine-hmp-cmds.c
parentfaad584adb48737aa3b39984786442a1a9c42aa4 (diff)
downloadfocaccia-qemu-c978bd5226f1ed73456ac468a7ed50af3d24dc84.tar.gz
focaccia-qemu-c978bd5226f1ed73456ac468a7ed50af3d24dc84.zip
qapi: Clean up visitor's recovery from input with invalid type
An alternate type's visit_type_FOO() fails when it runs into an
invalid ->type.  If it's an input visit, we then need to free the the
object we got from visit_start_alternate().  We do that with
qapi_free_FOO(), which uses the dealloc visitor.

Trouble is that object is in a bad state: its ->type is invalid.  So
the dealloc visitor will run into the same error again, and the error
recovery skips deallocating the alternate's (invalid) alternative.
Works, because qapi_free_FOO() ignores the error.

Avoid it instead: free the messed up object with by g_free().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200424084338.26803-11-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'hw/core/machine-hmp-cmds.c')
0 files changed, 0 insertions, 0 deletions