summary refs log tree commit diff stats
path: root/hw/core/machine-smp.c
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2024-11-10 23:09:01 +0800
committerPaolo Bonzini <pbonzini@redhat.com>2024-11-19 18:38:25 +0100
commit37ee17eebb93eb485fc122452a4c7e9202a8b449 (patch)
tree0fc4b197afaf883830fa0d85601c572802630387 /hw/core/machine-smp.c
parent9c2644948c71db61a04f22398cde72224a98267a (diff)
downloadfocaccia-qemu-37ee17eebb93eb485fc122452a4c7e9202a8b449.tar.gz
focaccia-qemu-37ee17eebb93eb485fc122452a4c7e9202a8b449.zip
hw/core/machine-smp: Fix error message parameter
In the loop checking smp cache support, the error message should report
the current cache level and type.

Fix the parameter of error_setg() to ensure it reports the correct cache
level and type.

Resolves: Coverity CID 1565391
Fixes: f35c0221fef8 ("hw/core: Check smp cache topology support for machine")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/20241110150901.130647-3-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/core/machine-smp.c')
-rw-r--r--hw/core/machine-smp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
index b87637c78f..b954eb8490 100644
--- a/hw/core/machine-smp.c
+++ b/hw/core/machine-smp.c
@@ -317,7 +317,7 @@ bool machine_parse_smp_cache(MachineState *ms,
             !mc->smp_props.cache_supported[props->cache]) {
             error_setg(errp,
                        "%s cache topology not supported by this machine",
-                       CacheLevelAndType_str(node->value->cache));
+                       CacheLevelAndType_str(props->cache));
             return false;
         }