summary refs log tree commit diff stats
path: root/hw/core
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-12-28 14:40:41 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2019-02-05 16:50:18 +0100
commit82e870bac441f231deb72b64c9baf2f2fbd5bdbb (patch)
tree222eef2927695d383133546f3ee2b4165ea263b5 /hw/core
parent1b9d35f33c85e63377b02eba276dd1bb102247f9 (diff)
downloadfocaccia-qemu-82e870bac441f231deb72b64c9baf2f2fbd5bdbb.tar.gz
focaccia-qemu-82e870bac441f231deb72b64c9baf2f2fbd5bdbb.zip
monitor: do not use QTAILQ_FOREACH_SAFE across critical sections
monitor_qmp_requests_pop_any_with_lock cannot modify the monitor list
concurrently with monitor_cleanup, since the dispatch bottom half
runs in the main thread, but anyway it is a bit ugly to keep
"next" live across critical sections of monitor_lock and Coverity
complains (CID 1397072).

Replace QTAILQ_FOREACH_SAFE with a while loop and QTAILQ_FIRST,
it is cleaner and more future-proof.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/core')
0 files changed, 0 insertions, 0 deletions