summary refs log tree commit diff stats
path: root/hw/display/qxl-render.c
diff options
context:
space:
mode:
authorGerd Hoffmann <kraxel@redhat.com>2017-08-28 14:29:06 +0200
committerGerd Hoffmann <kraxel@redhat.com>2017-09-01 13:52:43 +0200
commit3d90c6254863693a6b13d918d2b8682e08bbc681 (patch)
tree41f305d2ad30ffad4ea463ca2c89f83e53eb2067 /hw/display/qxl-render.c
parente65294157d4b69393b3f819c99f4f647452b48e3 (diff)
downloadfocaccia-qemu-3d90c6254863693a6b13d918d2b8682e08bbc681.tar.gz
focaccia-qemu-3d90c6254863693a6b13d918d2b8682e08bbc681.zip
vga: stop passing pointers to vga_draw_line* functions
Instead pass around the address (aka offset into vga memory).
Add vga_read_* helper functions which apply vbe_size_mask to
the address, to make sure the address stays within the valid
range, similar to the cirrus blitter fixes (commits ffaf857778
and 026aeffcb4).

Impact:  DoS for privileged guest users.  qemu crashes with
a segfault, when hitting the guard page after vga memory
allocation, while reading vga memory for display updates.

Fixes: CVE-2017-13672
Cc: P J P <ppandit@redhat.com>
Reported-by: David Buchanan <d@vidbuchanan.co.uk>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20170828122906.18993-1-kraxel@redhat.com
Diffstat (limited to 'hw/display/qxl-render.c')
0 files changed, 0 insertions, 0 deletions