diff options
| author | Stefan Weil <sw@weilnetz.de> | 2012-03-08 22:58:06 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2012-03-19 10:52:52 +0000 |
| commit | ee032ca146e932ce616aff7762596a10bf24ecac (patch) | |
| tree | fdb3795a677d6e6825506d82b3564709d61da580 /hw/ds1338.c | |
| parent | b920df5c79f64fe9617ef070cd6bda1738172f84 (diff) | |
| download | focaccia-qemu-ee032ca146e932ce616aff7762596a10bf24ecac.tar.gz focaccia-qemu-ee032ca146e932ce616aff7762596a10bf24ecac.zip | |
vnc: Fix packed boolean struct members
This patch fixes warnings reported by splint: For variables which are packed in a single bit, a signed data type like 'int' does not make much sense. There is no obvious reason why the two values should be packed, so I removed the packing and changed the data type to bool because both are used as boolean values. v2: Some versions of gcc complain after this modification, for example gcc (Debian 4.4.5-8) 4.4.5): ui/vnc-auth-sasl.c: In function ‘vnc_sasl_client_cleanup’: ui/vnc-auth-sasl.c:34: error: suggest parentheses around assignment used as truth value Obviously, the compiler does not like code which does bool = unsigned = bool = 0 Splitting that code in three statements works. Cc: Anthony Liguori <aliguori@us.ibm.com> Signed-off-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'hw/ds1338.c')
0 files changed, 0 insertions, 0 deletions