summary refs log tree commit diff stats
path: root/hw/grlib_apbuart.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>2011-04-14 18:11:00 +0100
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>2011-04-26 13:14:49 +0100
commitb4548fcc0314f5e118ed45b5774e9cd99f9a97d3 (patch)
treecfa89cbb83dadb4889c1d9e5cfe49aee15a581c7 /hw/grlib_apbuart.c
parent1a96dd472c37ceeefc0d488cb7722c6714d2f0b7 (diff)
downloadfocaccia-qemu-b4548fcc0314f5e118ed45b5774e9cd99f9a97d3.tar.gz
focaccia-qemu-b4548fcc0314f5e118ed45b5774e9cd99f9a97d3.zip
trace: Remove %s in grlib trace events
Trace events cannot use %s in their format strings because trace
backends vary in how they can deference pointers (if at all).  Recording
const char * values is not meaningful if their contents are not recorded
too.

Change grlib trace events that rely on strings so that they communicate
similar information without using strings.

A follow-up patch explains this limitation and updates docs/tracing.txt.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'hw/grlib_apbuart.c')
-rw-r--r--hw/grlib_apbuart.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/grlib_apbuart.c b/hw/grlib_apbuart.c
index 101b150aa5..169a56eb1b 100644
--- a/hw/grlib_apbuart.c
+++ b/hw/grlib_apbuart.c
@@ -133,7 +133,7 @@ grlib_apbuart_writel(void *opaque, target_phys_addr_t addr, uint32_t value)
         break;
     }
 
-    trace_grlib_apbuart_unknown_register("write", addr);
+    trace_grlib_apbuart_writel_unknown(addr, value);
 }
 
 static CPUReadMemoryFunc * const grlib_apbuart_read[] = {