summary refs log tree commit diff stats
path: root/hw/i2c
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@redhat.com>2020-04-22 15:31:46 +0200
committerLaurent Vivier <laurent@vivier.eu>2020-05-04 14:43:24 +0200
commit00d1d29b768d920342c5e33cc56a9e0be596b2b4 (patch)
treed4038e0a307e034b38c47b8ee303044b15a02645 /hw/i2c
parent1fe5a8c2cd5dc0da03a4246474abf37f0e8cc8c0 (diff)
downloadfocaccia-qemu-00d1d29b768d920342c5e33cc56a9e0be596b2b4.tar.gz
focaccia-qemu-00d1d29b768d920342c5e33cc56a9e0be596b2b4.zip
hw/i2c/pm_smbus: Remove dead assignment
Fix warning reported by Clang static code analyzer:

    CC      hw/i2c/pm_smbus.o
  hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read
                  ret = 0;
                  ^     ~

Reported-by: Clang Static Analyzer
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200422133152.16770-4-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/i2c')
-rw-r--r--hw/i2c/pm_smbus.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
index 36994ff585..4728540c37 100644
--- a/hw/i2c/pm_smbus.c
+++ b/hw/i2c/pm_smbus.c
@@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s)
                 s->smb_stat |= STS_HOST_BUSY | STS_BYTE_DONE;
                 s->smb_data[0] = s->smb_blkdata;
                 s->smb_index = 0;
-                ret = 0;
             }
             goto out;
         }