diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-10-17 10:26:32 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-10-19 14:51:34 +0200 |
| commit | 1245402e3c9be20200dcc469805f4156d93381e2 (patch) | |
| tree | 9dbb672b9bcf1690a68e53b97f3de5e2b3339059 /hw/intc/ioapic.c | |
| parent | b1b769b0f3fd672886ade16da07b540acafeb1cc (diff) | |
| download | focaccia-qemu-1245402e3c9be20200dcc469805f4156d93381e2.tar.gz focaccia-qemu-1245402e3c9be20200dcc469805f4156d93381e2.zip | |
9pfs: Fix CLI parsing crash on error
Calling error_report() in a function that takes an Error ** argument
is suspicious. 9p-handle.c's handle_parse_opts() does that, and then
fails without setting an error. Wrong. Its caller crashes when it
tries to report the error:
$ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=handle
qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: warning: handle backend is deprecated
qemu-system-x86_64: -fsdev id=foo,fsdriver=handle: fsdev: No path specified
Segmentation fault (core dumped)
Screwed up when commit 91cda4e8f37 (v2.12.0) converted the function to
Error. Fix by calling error_setg() instead of error_report().
Fixes: 91cda4e8f372602795e3a2f4bd2e3adaf9f82255
Cc: Greg Kurz <groug@kaod.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181017082702.5581-9-armbru@redhat.com>
Diffstat (limited to 'hw/intc/ioapic.c')
0 files changed, 0 insertions, 0 deletions