summary refs log tree commit diff stats
path: root/hw/intc/xilinx_intc.c
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2013-06-04 13:18:17 +0800
committerStefan Hajnoczi <stefanha@redhat.com>2013-06-07 15:48:11 +0200
commitc87826a878be05208c3906eb9d5e1f37cff5e98e (patch)
tree6519afe70da0729db329fbc7c1b259dfa41987a5 /hw/intc/xilinx_intc.c
parent3ffee3cd5fb29de2115bdcbde0a02f47ce69a24c (diff)
downloadfocaccia-qemu-c87826a878be05208c3906eb9d5e1f37cff5e98e.tar.gz
focaccia-qemu-c87826a878be05208c3906eb9d5e1f37cff5e98e.zip
tap: fix NULL dereference when passing invalid parameters to tap
This patch forbid the following invalid parameters to tap:

1) fd and vhostfds were specified but vhostfd were not specified
2) vhostfds were specified but fds were not specified
3) fds and vhostfd were specified

For 1 and 2, net_init_tap_one() will still pass NULL as vhostfdname to
monitor_handle_fd_param(), which may crash the qemu.

Also remove the unnecessary has_fd check.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <shajnocz@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/intc/xilinx_intc.c')
0 files changed, 0 insertions, 0 deletions