summary refs log tree commit diff stats
path: root/hw/mips/loongson3_virt.c
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2025-03-28 12:55:26 -0500
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2025-03-31 21:32:43 +0200
commit256ba7715b109c080c0c77a3923df9e69736ba17 (patch)
tree33b157f474a3bd00bc76edbb8414359e60804702 /hw/mips/loongson3_virt.c
parentd89b9899babcc01d7ee75f2917da861dc2afbc27 (diff)
downloadfocaccia-qemu-256ba7715b109c080c0c77a3923df9e69736ba17.tar.gz
focaccia-qemu-256ba7715b109c080c0c77a3923df9e69736ba17.zip
target/mips: Simplify and fix update_pagemask
When update_pagemask was split from helper_mtc0_pagemask,
we failed to actually write to the new parameter but continue
to write to env->CP0_PageMask.  Thus the use within
page_table_walk_refill modifies cpu state and not the local
variable as expected.

Simplify by renaming to compute_pagemask and returning the
value directly.  No need for either env or pointer return.

Fixes: 074cfcb4dae ("target/mips: Implement hardware page table walker for MIPS32")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250328175526.368121-4-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: qemu-stable@nongnu.org
Diffstat (limited to 'hw/mips/loongson3_virt.c')
0 files changed, 0 insertions, 0 deletions