diff options
| author | Cédric Le Goater <clg@kaod.org> | 2023-06-07 06:39:32 +0200 |
|---|---|---|
| committer | Cédric Le Goater <clg@kaod.org> | 2023-06-15 18:35:57 +0200 |
| commit | c8f48b120b31f6bbe33135ef5d478e485c37e3c2 (patch) | |
| tree | f6f071585f307e88b2c7cb78660533213b336aa2 /hw/misc/aspeed_hace.c | |
| parent | be85508f174def8f13cac3855368a27592a6ea1b (diff) | |
| download | focaccia-qemu-c8f48b120b31f6bbe33135ef5d478e485c37e3c2.tar.gz focaccia-qemu-c8f48b120b31f6bbe33135ef5d478e485c37e3c2.zip | |
aspeed/hace: Initialize g_autofree pointer
As mentioned in docs/devel/style.rst "Automatic memory deallocation":
* Variables declared with g_auto* MUST always be initialized,
otherwise the cleanup function will use uninitialized stack memory
This avoids QEMU to coredump when running the "hash test" command
under Zephyr.
Cc: Steven Lee <steven_lee@aspeedtech.com>
Cc: Joel Stanley <joel@jms.id.au>
Cc: qemu-stable@nongnu.org
Fixes: c5475b3f9a ("hw: Model ASPEED's Hash and Crypto Engine")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Message-Id: <20230421131547.2177449-1-clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to '')
| -rw-r--r-- | hw/misc/aspeed_hace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 12a761f1f5..b07506ec04 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -189,7 +189,7 @@ static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode, bool acc_mode) { struct iovec iov[ASPEED_HACE_MAX_SG]; - g_autofree uint8_t *digest_buf; + g_autofree uint8_t *digest_buf = NULL; size_t digest_len = 0; int niov = 0; int i; |